Skip to content

fix: fix preview from Sidekick #4817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2019
Merged

fix: fix preview from Sidekick #4817

merged 1 commit into from
Jul 8, 2019

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Jul 8, 2019

Currently CLI doesn't detach the PREPARE_READY_EVENT on stopPreview and this led to executing multiple times the livesync operation from sidekick.

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

Currently CLI doesn't detach the PREPARE_READY_EVENT on stopPreview and this led to executing multiple times the livesync operation from sidekick.
@cla-bot cla-bot bot added the cla: yes label Jul 8, 2019
@Fatme
Copy link
Contributor Author

Fatme commented Jul 8, 2019

test cli-preview

1 similar comment
@Fatme
Copy link
Contributor Author

Fatme commented Jul 8, 2019

test cli-preview

@Fatme
Copy link
Contributor Author

Fatme commented Jul 8, 2019

test cli-preview

@Fatme
Copy link
Contributor Author

Fatme commented Jul 8, 2019

test cli-preview nativescript-dev-webpack#1.0.0-rc-2019-07-05-084857-01

@Fatme Fatme merged commit fb99829 into release Jul 8, 2019
@Fatme Fatme deleted the fatme/fix-preview branch July 8, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants